sync-diff-inspector: add descriptions and examples of table routers #15242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
missing-translation-status
|
/cc @Leavrth |
|
/cc @hfxsd |
|
/cc @ran-huang |
hfxsd
added
translation/doing
hfxsd
added
the
translation/welcome
Leavrth
approved these changes
Dec 11, 2023
sync-diff-inspector/route-diff.md
Outdated
|
|
||
| - If there is a table `schema` in the upstream, but no rule matches the table, sync-diff-inspector will add a new rule `schema -> _no__exists__db_` to the table router. After that, sync-diff-inspector will treat the table `schema` as the table `_no__exists__db_`. | ||
|
|
||
| If `target-schema.target-table` does not exist in the rules, sync-diff-inspector will add a rule to match`target-schema.target-table` to `target-schema.target-table` to make it case-insensitive, because the table router is case-insensitive. |
There was a problem hiding this comment.
Suggested change
| If `target-schema.target-table` does not exist in the rules, sync-diff-inspector will add a rule to match`target-schema.target-table` to `target-schema.target-table` to make it case-insensitive, because the table router is case-insensitive. | |
| If `target-schema.target-table` does not exist in the rules, sync-diff-inspector will add a rule to match `target-schema.target-table` to `target-schema.target-table` to make it case-insensitive, because the table router is case-insensitive. |
sync-diff-inspector/route-diff.md
Outdated
|
|
||
| ### Examples | ||
|
|
||
| Suppose there are seven tables: |
There was a problem hiding this comment.
Suggested change
| Suppose there are seven tables: | |
| Suppose there are seven tables in the upstream cluster: |
|
@Leavrth: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Jianjun Liao <[email protected]>
hfxsd
added
the
needs-cherry-pick-release-7.5
hfxsd
reviewed
Dec 12, 2023
hfxsd
changed the title
18 tasks
hfxsd
added
translation/done
hfxsd
removed
the
translation/welcome
ran-huang
approved these changes
Dec 13, 2023
hfxsd
approved these changes
Dec 14, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
17 tasks
|
In response to a cherrypick label: new pull request created to branch |
Merged
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?