Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add missing dynamic privileges and update optm lock version #12541

Merged
merged 7 commits into from
Feb 20, 2023
Merged

sql: add missing dynamic privileges and update optm lock version #12541

merged 7 commits into from
Feb 20, 2023

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Feb 17, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add missing dynamic privileges and update the version that supports optimistic locking to v3.0.8.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn February 17, 2023 04:24
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 17, 2023
@shichun-0415 shichun-0415 added type/bugfix This PR fixes a bug. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. ONCALL Relates to documentation oncall. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.4 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. and removed missing-translation-status This PR does not have translation status info. labels Feb 17, 2023
@shichun-0415 shichun-0415 changed the title add missing dynamic privileges and update optm lock version sql: add missing dynamic privileges and update optm lock version Feb 17, 2023
djshow832
djshow832 reviewed Feb 17, 2023
View reviewed changes
shichun-0415
shichun-0415 commented Feb 20, 2023
View reviewed changes
@shichun-0415 shichun-0415 requested review from Oreoxmt and removed request for TomShawn February 20, 2023 06:46
Oreoxmt
Oreoxmt approved these changes Feb 20, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2023
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@shichun-0415: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@shichun-0415
Copy link
Contributor Author

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 20, 2023
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a902a4e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 20, 2023
@shichun-0415 shichun-0415 merged commit 88693d7 into pingcap:master Feb 20, 2023
@shichun-0415 shichun-0415 deleted the align-two-docs branch February 20, 2023 06:59
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 20, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #12580.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 20, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12581.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 20, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #12582.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 20, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #12583.

ti-chi-bot added a commit that referenced this pull request Feb 20, 2023
@ti-chi-bot
sql: add missing dynamic privileges and update optm lock version (#12541
3a037f3 
) (#12583)
ti-chi-bot added a commit that referenced this pull request Feb 20, 2023
@ti-chi-bot
sql: add missing dynamic privileges and update optm lock version (#12541
3547fb7 
) (#12582)
ti-chi-bot added a commit that referenced this pull request Feb 20, 2023
@ti-chi-bot
sql: add missing dynamic privileges and update optm lock version (#12541
fbdacc8 
) (#12581)
ti-chi-bot added a commit that referenced this pull request Feb 20, 2023
@ti-chi-bot
sql: add missing dynamic privileges and update optm lock version (#12541
67a3f64 
) (#12580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees
No one assigned
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shichun-0415 @ti-chi-bot @djshow832 @Oreoxmt @TomShawn