binlog: add Create View to privileges required by Pump #12256

shichun-0415 · 2023-01-28T08:08:54Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

According to the following information, Pump also needs the Create View privilege to replicate data:

mysql> show grants for repl;
+----------------------------------------------------------------------------------------+
| Grants for repl@% |
+----------------------------------------------------------------------------------------+
| GRANT SELECT,INSERT,UPDATE,DELETE,CREATE,DROP,ALTER,EXECUTE,INDEX ON . TO 'repl'@'%' |
+----------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

mysql> CREATE TABLE t1 (id INT NOT NULL PRIMARY KEY AUTO_INCREMENT, c1 INT NOT NULL);
Query OK, 0 rows affected (0.10 sec)

mysql> INSERT INTO t1 (c1) VALUES (1),(2),(3),(4),(5);
Query OK, 5 rows affected (0.02 sec)
Records: 5 Duplicates: 0 Warnings: 0

mysql> CREATE VIEW v1 AS SELECT * FROM t1 WHERE c1 > 2;
ERROR 1142 (42000): CREATE VIEW command denied to user 'repl'@'%' for table 'v1'

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

What is the related PR or file link(s)?

This PR is translated from: Add Create View Privilege docs-cn#11189
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

ti-chi-bot · 2023-01-28T08:08:56Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Oreoxmt
lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

lichunzhu

LGTM

Oreoxmt

LGTM

shichun-0415 · 2023-01-30T02:59:36Z

/merge

ti-chi-bot · 2023-01-30T02:59:39Z

This pull request has been accepted and is ready to merge.

Commit hash: 55c9944

ti-chi-bot · 2023-01-30T03:11:56Z

@shichun-0415: new pull request could not be created: failed to create pull request against pingcap/docs#release-5.0 from head ti-chi-bot:cherry-pick-12256-to-release-5.0: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#secondary-rate-limits"}

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

shichun-0415 · 2023-01-31T10:04:46Z

/cherrypick release-5.0
/cherrypick release-5.1
/cherrypick release-5.2
/cherrypick release-5.3
/cherrypick release-5.4
/cherrypick release-6.1
/cherrypick release-6.3
/cherrypick release-6.4
/cherrypick release-6.5

ti-chi-bot · 2023-01-31T10:05:25Z

@shichun-0415: new pull request created to branch release-5.0: #12322.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-31T10:06:06Z

@shichun-0415: new pull request created to branch release-5.1: #12323.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-31T10:06:46Z

@shichun-0415: new pull request created to branch release-5.2: #12324.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-31T10:07:28Z

@shichun-0415: new pull request created to branch release-5.3: #12326.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-31T10:08:10Z

@shichun-0415: new pull request created to branch release-5.4: #12328.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-31T10:08:51Z

@shichun-0415: new pull request created to branch release-6.1: #12330.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-31T10:09:31Z

@shichun-0415: new pull request created to branch release-6.3: #12332.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-31T10:10:12Z

@shichun-0415: new pull request created to branch release-6.4: #12333.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-31T10:10:52Z

@shichun-0415: new pull request created to branch release-6.5: #12334.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

binlog: add Create View to privileges required by Pump

55c9944

ti-chi-bot requested a review from Oreoxmt January 28, 2023 08:09

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2023

shichun-0415 requested a review from lichunzhu January 28, 2023 08:32

lichunzhu approved these changes Jan 28, 2023

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 28, 2023

shichun-0415 removed the require-LGT1 Indicates that the PR requires an LGTM. label Jan 28, 2023

Oreoxmt approved these changes Jan 28, 2023

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 28, 2023

shichun-0415 closed this Jan 30, 2023

shichun-0415 reopened this Jan 30, 2023

This comment was marked as outdated.

Sign in to view

ti-chi-bot mentioned this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) #12322

Merged

15 tasks

ti-chi-bot mentioned this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) #12323

Merged

15 tasks

ti-chi-bot mentioned this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) #12324

Merged

15 tasks

ti-chi-bot mentioned this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) #12326

Merged

15 tasks

ti-chi-bot mentioned this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) #12328

Merged

15 tasks

ti-chi-bot mentioned this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) #12330

Merged

15 tasks

ti-chi-bot mentioned this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) #12332

Merged

15 tasks

ti-chi-bot mentioned this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) #12333

Merged

15 tasks

ti-chi-bot mentioned this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) #12334

Merged

15 tasks

ti-chi-bot added a commit that referenced this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) (#12326)

e1e1de4

ti-chi-bot added a commit that referenced this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) (#12328)

a4c6e7c

ti-chi-bot added a commit that referenced this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) (#12330)

da07048

ti-chi-bot added a commit that referenced this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) (#12332)

00b2422

ti-chi-bot added a commit that referenced this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) (#12333)

b35ae6f

ti-chi-bot added a commit that referenced this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) (#12334)

9de913c

ti-chi-bot added a commit that referenced this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) (#12323)

c74f14d

ti-chi-bot added a commit that referenced this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) (#12322)

57e45da

ti-chi-bot added a commit that referenced this pull request Jan 31, 2023

binlog: add Create View to privileges required by Pump (#12256) (#12324)

999fec7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

binlog: add Create View to privileges required by Pump #12256

binlog: add Create View to privileges required by Pump #12256

shichun-0415 commented Jan 28, 2023 •

edited

Loading

ti-chi-bot commented Jan 28, 2023 •

edited

Loading

lichunzhu left a comment

Oreoxmt left a comment

shichun-0415 commented Jan 30, 2023

ti-chi-bot commented Jan 30, 2023

This comment was marked as outdated.

ti-chi-bot commented Jan 30, 2023

shichun-0415 commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

binlog: add Create View to privileges required by Pump #12256

binlog: add Create View to privileges required by Pump #12256

Conversation

shichun-0415 commented Jan 28, 2023 • edited Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Jan 28, 2023 • edited Loading

lichunzhu left a comment

Choose a reason for hiding this comment

Oreoxmt left a comment

Choose a reason for hiding this comment

shichun-0415 commented Jan 30, 2023

ti-chi-bot commented Jan 30, 2023

This comment was marked as outdated.

ti-chi-bot commented Jan 30, 2023

shichun-0415 commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

ti-chi-bot commented Jan 31, 2023

shichun-0415 commented Jan 28, 2023 •

edited

Loading

ti-chi-bot commented Jan 28, 2023 •

edited

Loading