Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Grace Cai <[email protected]>
  • Loading branch information
en-jin19 and qiancai authored Mar 3, 2022
1 parent ba4fc1b commit bf1753d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions clinic/clinic-data-instruction-for-tiup.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ This section lists the types of diagnostic data that can be collected by Diag fr
| All metrics data | `{metric_name}.json` | `--include=monitor` |
| All alerts data | `alerts.json` | `--include=monitor` |

### TiDB system variable
### TiDB system variables

| Data type | Exported file | Parameter for data collection by TiDB Clinic |
| :------ | :------ |:-------- |
Expand All @@ -93,7 +93,7 @@ This section lists the types of diagnostic data that can be collected by Diag fr
| Basic information of the system and hardware | `insight.json` | `--include=system` |
| Contents in the `/etc/security/limits.conf` | `limits.conf` | `--include=system` |
| List of kernel parameters | `sysctl.conf` | `--include=system` |
| Socket system information, which is the output of the ss command | `ss.txt` | `--include=system` |
| Socket system information, which is the output of the `ss` command | `ss.txt` | `--include=system` |

## DM clusters

Expand Down Expand Up @@ -137,4 +137,4 @@ This section lists the types of diagnostic data that can be collected by Diag fr
| Basic information of the system and hardware | `insight.json` | `--include=system` |
| Contents in the `/etc/security/limits.conf` system | `limits.conf` | `--include=system` |
| List of kernel parameters | `sysctl.conf` | `--include=system` |
| Socket system information, which is the output of the ss command | `ss.txt` | `--include=system` |
| Socket system information, which is the output of the `ss` command | `ss.txt` | `--include=system` |
6 changes: 3 additions & 3 deletions clinic/clinic-user-guide-for-tiup.md
Original file line number Diff line number Diff line change
Expand Up @@ -214,15 +214,15 @@ After the upload is complete, you need to send the data access link of `Download

If the network where your cluster is located cannot access the internet, you need to pack the data on your intranet and upload the data package to the Clinic Server using a device with internet access. The detailed operations are as follows:

1. Pack collected in [Step 2. Collect data](#step-2-collect-data) and compress and encrypt the data package by running the following command:
1. Pack the collected data obtained in [Step 2. Collect data](#step-2-collect-data) by running the following command:

{{< copyable "shell-regular" >}}

```bash
tiup diag package ${filepath}
```

While packaging, Diag encrypts and compresses the data at the same time. In the test environment, 800 MB of data was compressed to 57 MB. The following is an example output:
During packaging, Diag encrypts and compresses the data at the same time. In the test environment, 800 MB of data was compressed to 57 MB. The following is an example output:

```bash
Starting component `diag`: /root/.tiup/components/diag/v0.5.1/diag package diag-fNTnz5MGhr6
Expand Down Expand Up @@ -256,7 +256,7 @@ If the network where your cluster is located cannot access the internet, you nee
Download URL: "https://clinic.pingcap.com:4433/diag/files?uuid=XXXX"
```

After the upload is complete, you need to send the data access link of `Download URL` to the PingCAP technical support staff you contacted before.
3. After the upload is complete, send the data access link of `Download URL` to the PingCAP technical support staff you contacted before.

> **Note:**
>
Expand Down

0 comments on commit bf1753d

Please sign in to comment.