Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

zh,en: update precheck items #517

Merged
merged 4 commits into from
Dec 25, 2020
Merged

zh,en: update precheck items #517

merged 4 commits into from
Dec 25, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Dec 18, 2020

What is changed, added, or deleted? (Required)

update precheck items for v2.0.1

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v3.0 changes)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

pingcap/dm#1315

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

csuzhangxc
csuzhangxc reviewed Dec 18, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2020
@CharLotteiu CharLotteiu added needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. status/PTAL This PR is ready for reviewing. translation/no-need The changes in this PR don't need to be translated. labels Dec 18, 2020
@CharLotteiu CharLotteiu requested a review from yikeke December 18, 2020 08:25
yikeke
yikeke approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 18, 2020
@yikeke
Copy link
Contributor

yikeke commented Dec 18, 2020

Should we merge this PR after v2.0.1 is released? @csuzhangxc @GMHDBJD

@csuzhangxc csuzhangxc mentioned this pull request Dec 18, 2020
Merged
7 tasks
@ti-srebot
Copy link
Contributor

@csuzhangxc, @yikeke, @ti-srebot, PTAL.

@ti-srebot
Copy link
Contributor

@csuzhangxc, @yikeke, PTAL.

@CharLotteiu CharLotteiu merged commit 8029267 into pingcap:master Dec 25, 2020
ti-srebot pushed a commit to ti-srebot/docs-dm that referenced this pull request Dec 25, 2020
@GMHDBJD @ti-srebot
cherry pick pingcap#517 to release-2.0
22dae7b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Dec 25, 2020
Merged
7 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.0 in PR #529

CharLotteiu pushed a commit that referenced this pull request Dec 25, 2020
@ti-srebot @GMHDBJD
cherry pick #517 to release-2.0 (#529)
dc5f6e9 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: GMHDBJD <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@yikeke yikeke yikeke approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GMHDBJD @yikeke @ti-srebot @csuzhangxc @CharLotteiu