Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ambiguous-words: clarify words in scheduling related docs #9904

Merged
merged 2 commits into from
Jun 21, 2022
Merged

ambiguous-words: clarify words in scheduling related docs #9904

merged 2 commits into from
Jun 21, 2022

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

ambiguous-words: clarify words in scheduling related docs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@TomShawn TomShawn requested review from nolouch and Oreoxmt June 20, 2022 06:18
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Jun 20, 2022
@TomShawn TomShawn self-assigned this Jun 20, 2022
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2022
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. ambiguous-words needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2022
Oreoxmt
Oreoxmt reviewed Jun 20, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 21, 2022
Oreoxmt
Oreoxmt approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2022
@TomShawn
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2022
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 390433f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2022
@ti-chi-bot ti-chi-bot merged commit 75dc83d into pingcap:master Jun 21, 2022
@TomShawn TomShawn deleted the ambiguous-words-2 branch June 21, 2022 09:20
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 21, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9921.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 21, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #9922.

TomShawn added a commit that referenced this pull request Jun 21, 2022
@ti-chi-bot @TomShawn @Oreoxmt
ambiguous-words: clarify words in scheduling related docs (#9904) (#9922
b3c07d4 
)

* ambiguous-words: clarify words in scheduling related docs

* Apply suggestions from code review

Co-authored-by: Aolin <[email protected]>

Co-authored-by: TomShawn <[email protected]>
Co-authored-by: Aolin <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jun 21, 2022
@ti-chi-bot
ambiguous-words: clarify words in scheduling related docs (#9904) (#9921
02c5da3 
)
@TomShawn TomShawn mentioned this pull request Jun 22, 2022
Merged
12 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 22, 2022
This was referenced Jun 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@TomShawn TomShawn

Labels
ambiguous-words area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @ti-chi-bot @nolouch @Oreoxmt