-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ambiguous words: clarify tools words #9775
Conversation
Co-authored-by: shichun-0415 <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@@ -72,7 +72,7 @@ BR 可以直接将命令下发到 TiKV 集群来执行备份和恢复,不依 | |||
运行 [`br backup`](/br/use-br-command-line-tool.md#br-命令行描述) 命令进行备份前,请确保以下条件: | |||
|
|||
1. TiDB 集群中没有正在运行中的 DDL。 | |||
2. 用于创建备份的存储设备有足够的空间。 | |||
2. 用于创建备份的存储设备有足够的空间(具有备份集群的 1/3 的磁盘空间即可)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed with @3pointer
/remove-status LGT1 |
@TomShawn: These labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
/merge cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1f42a65
|
In response to a cherrypick label: new pull request created: #9841. |
In response to a cherrypick label: new pull request created: #9842. |
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: TomShawn <[email protected]>
What is changed, added or deleted? (Required)
ambiguous words: clarify tools words for lighting, dm, dumpling storage space
Except for the BR doc, all changes are confirmed by @sunzhaoyang.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?