Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "update bcj threshold" #6926

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Revert "update bcj threshold" #6926

merged 1 commit into from
Aug 24, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Aug 24, 2021 •
edited
Loading

Reverts #6875

Translated in pingcap/docs#6232.

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/bugfix This PR fixes a bug. v5.2 This PR/issue applies to TiDB v5.2. labels Aug 24, 2021
@TomShawn TomShawn self-assigned this Aug 24, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 24, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Liuxiaozhen12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 24, 2021
@TomShawn TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2021
LittleFall
LittleFall approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@LittleFall: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LittleFall LittleFall mentioned this pull request Aug 24, 2021
Merged
11 tasks
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2021
@TomShawn TomShawn mentioned this pull request Aug 24, 2021
Merged
11 tasks
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 24, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5f5fc61

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2021
@ti-chi-bot ti-chi-bot merged commit 5b9ed2d into master Aug 24, 2021
@TomShawn TomShawn deleted the revert-6875-hanfei/update-bcj-var branch August 24, 2021 07:54
@TomShawn TomShawn mentioned this pull request Aug 26, 2021
Merged
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 26, 2021
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liuxiaozhen12 Liuxiaozhen12 Liuxiaozhen12 approved these changes

@LittleFall LittleFall LittleFall approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees

@TomShawn TomShawn

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. require-LGT1 Indicates that the PR requires an LGTM. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug. v5.2 This PR/issue applies to TiDB v5.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @ti-chi-bot @LittleFall @Liuxiaozhen12