Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update PR template for v5.2 #6865

Merged
merged 1 commit into from
Aug 25, 2021
Merged

update PR template for v5.2 #6865

merged 1 commit into from
Aug 25, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Aug 16, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

update PR template for v5.2

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2021
@TomShawn TomShawn requested a review from qiancai August 16, 2021 02:48
@TomShawn TomShawn self-assigned this Aug 16, 2021
@TomShawn TomShawn added needs-cherry-pick-release-3.1 require-LGT1 Indicates that the PR requires an LGTM. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Aug 16, 2021
@TomShawn TomShawn mentioned this pull request Aug 16, 2021
Merged
12 tasks
qiancai
qiancai approved these changes Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aba11d2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2021
This was referenced Aug 25, 2021
Merged
Merged
Merged
@ti-chi-bot ti-chi-bot merged commit 7544eb6 into pingcap:master Aug 25, 2021
@TomShawn TomShawn deleted the update05.2-pr branch August 25, 2021 06:18
This was referenced Aug 25, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6937.

This was referenced Aug 25, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6938.

This was referenced Aug 25, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6939.

This was referenced Aug 25, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6940.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6941.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6942.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6944.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2021
Merged
12 tasks
ti-chi-bot added a commit that referenced this pull request Aug 25, 2021
@ti-chi-bot
update PR template for v5.2 (#6865) (#6937)
a65da49
ti-chi-bot added a commit that referenced this pull request Aug 25, 2021
@ti-chi-bot
update PR template for v5.2 (#6865) (#6938)
5d1d672
ti-chi-bot added a commit that referenced this pull request Aug 25, 2021
@ti-chi-bot
update PR template for v5.2 (#6865) (#6942)
c0cb283
ti-chi-bot added a commit that referenced this pull request Aug 25, 2021
@ti-chi-bot
update PR template for v5.2 (#6865) (#6940)
e6ca611
ti-chi-bot added a commit that referenced this pull request Aug 25, 2021
@ti-chi-bot
update PR template for v5.2 (#6865) (#6939)
217be05
ti-chi-bot added a commit that referenced this pull request Aug 25, 2021
@ti-chi-bot
update PR template for v5.2 (#6865) (#6941)
05f9191
ti-chi-bot added a commit that referenced this pull request Aug 25, 2021
@ti-chi-bot
update PR template for v5.2 (#6865) (#6944)
02e57ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees

@TomShawn TomShawn

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-chi-bot @qiancai