Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo error by zhlint(zh.md) #6634

Merged
merged 15 commits into from
Jul 15, 2021
Merged

fix typo error by zhlint(zh.md) #6634

merged 15 commits into from
Jul 15, 2021

Conversation

wph95
Copy link
Contributor

@wph95 wph95 commented Jul 6, 2021

No description provided.

@ti-chi-bot ti-chi-bot added the contribution This PR is from a community contributor. label Jul 6, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 6, 2021 09:18
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 6, 2021
TomShawn
TomShawn suggested changes Jul 6, 2021
View reviewed changes
@TomShawn TomShawn removed contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 6, 2021
wph95 and others added 2 commits July 7, 2021 11:38
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 7, 2021
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
generate-self-signed-certificates.md Outdated
@@ -36,7 +36,7 @@ apt install openssl
yum install openssl
```

也可以参考 OpenSSL 官方的[下载文档](https://www.openssl.org/source/) 进行安装。
也可以参考 OpenSSL 官方的[下载文档](https://www.openssl.org/source)进行安装。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

经验证确实有斜线

Suggested change
也可以参考 OpenSSL 官方的[下载文档](https://www.openssl.org/source)进行安装。
也可以参考 OpenSSL 官方的[下载文档](https://www.openssl.org/source/)进行安装。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我去优化zhmd 去识别这种情况。这个是一个误判

TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 7, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
TomShawn
TomShawn reviewed Jul 15, 2021
View reviewed changes
TomShawn
TomShawn approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 15, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 93c2052

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2021
@ti-chi-bot ti-chi-bot merged commit 7d1b880 into pingcap:master Jul 15, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@wph95 @3AceShowHand
fix typo error by zhlint(zh.md) (pingcap#6634)
67fc5ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wph95 @ti-chi-bot @TomShawn