Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align the Chinese expression of sign-in #6586

Merged
merged 1 commit into from
Jul 5, 2021
Merged

align the Chinese expression of sign-in #6586

merged 1 commit into from
Jul 5, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

What is changed, added or deleted? (Required)

To close #6477, change 登陆 to 登录

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 5, 2021 03:15
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/label needs-cherry-pick-release-5.1
/label needs-cherry-pick-release-5.0
/label needs-cherry-pick-release-4.0
/translation no-need

@ti-chi-bot ti-chi-bot added translation/no-need No need to translate this PR. needs-cherry-pick-release-5.1 and removed missing-translation-status This PR does not have translation status info. labels Jul 5, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from qiancai July 5, 2021 03:19
@Liuxiaozhen12 Liuxiaozhen12 changed the title change 登陆 to 登录 align the Chinese expression of sign-in Jul 5, 2021
TomShawn
TomShawn approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 5, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 5, 2021

@Liuxiaozhen12 Please avoid using Chinese characters in the branch name and commit names to avoid the possible encoding error. Thanks~

@TomShawn
Copy link
Contributor

TomShawn commented Jul 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8ed6833

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2021
@ti-chi-bot ti-chi-bot merged commit f87ef16 into pingcap:master Jul 5, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6601.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6602.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6603.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
align the Chinese expression of sign-in (#6586) (#6601)
fdb2b7c
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
align the Chinese expression of sign-in (#6586) (#6602)
53daa55
ti-chi-bot added a commit that referenced this pull request Jul 5, 2021
@ti-chi-bot
align the Chinese expression of sign-in (#6586) (#6603)
62a7340
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@Liuxiaozhen12 @3AceShowHand
align the Chinese expression of sign-in (pingcap#6586)
d80633c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@qiancai qiancai Awaiting requested review from qiancai

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

建议全局文本搜索下，将登陆改成登录
3 participants
@Liuxiaozhen12 @ti-chi-bot @TomShawn