Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supplement br doc #6296

Merged
merged 2 commits into from
Jul 8, 2021
Merged

supplement br doc #6296

merged 2 commits into from
Jul 8, 2021

Conversation

hey-hoho
Copy link
Contributor

@hey-hoho hey-hoho commented May 19, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added the contribution This PR is from a community contributor. label May 19, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn May 19, 2021 07:46
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2021
@TomShawn TomShawn requested a review from 3pointer May 19, 2021 08:50
@TomShawn TomShawn added needs-cherry-pick-release-4.0 sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. labels May 19, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 19, 2021
@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label May 25, 2021
3pointer
3pointer approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2021
TomShawn
TomShawn approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3879014

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/rebase

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6a6c652

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit 381571d into pingcap:release-5.0 Jul 8, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6637.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6638.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6639.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
supplement br doc (#6296) (#6637)
c695296
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
supplement br doc (#6296) (#6638)
9232496
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
supplement br doc (#6296) (#6639)
67adc33
@hey-hoho hey-hoho deleted the patch-2 branch July 14, 2021 06:14
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request Jul 19, 2021
Merged
11 tasks
@Liuxiaozhen12 Liuxiaozhen12 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 19, 2021
3AceShowHand pushed a commit to 3AceShowHand/docs-cn that referenced this pull request Jul 27, 2021
@ti-chi-bot @3AceShowHand
supplement br doc (pingcap#6296) (pingcap#6639)
b9e85b1
This was referenced Aug 5, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. contribution This PR is from a community contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hey-hoho @ti-chi-bot @TomShawn @3pointer @Liuxiaozhen12