Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update TiDB 6MB limit #6226

Merged
merged 5 commits into from
May 11, 2021
Merged

update TiDB 6MB limit #6226

merged 5 commits into from
May 11, 2021

Conversation

youjiali1995
Copy link
Contributor

@youjiali1995 youjiali1995 commented May 10, 2021 •
edited by TomShawn
Loading

Signed-off-by: youjiali1995 [email protected]

What is changed, added or deleted? (Required)

TiDB introduced txn-entry-size-limit in v5.0 and added it to the doc #5158, but there are some outdated descriptions left.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions) needs version-specific changes
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 10, 2021 08:42
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2021
@TomShawn TomShawn requested a review from cfzjywxk May 10, 2021 09:36
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels May 10, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 10, 2021
@TomShawn
Copy link
Contributor

TomShawn commented May 10, 2021 •
edited
Loading

@youjiali1995 Please fix the broken link CI failure. Thanks~

@cfzjywxk
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@cfzjywxk: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@youjiali1995
update TiDB 6MB limit
0ce86cd 
Signed-off-by: youjiali1995 <[email protected]>
@youjiali1995 youjiali1995 force-pushed the txn-entry-size-limit branch from e70c2c8 to 0ce86cd Compare May 10, 2021 11:04
TomShawn
TomShawn approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2021
TomShawn
TomShawn approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label May 11, 2021
@TomShawn TomShawn merged commit 521f861 into pingcap:master May 11, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request May 11, 2021
@youjiali1995 @ti-srebot
cherry pick pingcap#6226 to release-4.0
ee67778 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 11, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #6238

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request May 11, 2021
@youjiali1995 @ti-srebot
cherry pick pingcap#6226 to release-5.0
d75097e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request May 11, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #6239

TomShawn pushed a commit that referenced this pull request May 11, 2021
@ti-srebot @youjiali1995
cherry pick #6226 to release-5.0 (#6239)
9a3359a 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Lei Zhao <[email protected]>
@TomShawn TomShawn added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label May 11, 2021
TomShawn added a commit that referenced this pull request May 11, 2021
@ti-srebot @youjiali1995 @TomShawn
update TiDB 6MB limit (#6226) (#6238)
58aaca8 
* cherry pick #6226 to release-4.0

Signed-off-by: ti-srebot <[email protected]>

* resolve conflicts

* apply version specific changes

Co-authored-by: Lei Zhao <[email protected]>
Co-authored-by: TomShawn <[email protected]>
@Liuxiaozhen12 Liuxiaozhen12 mentioned this pull request May 20, 2021
Merged
10 tasks
@Liuxiaozhen12
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 20, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 20, 2021
@youjiali1995 @ti-chi-bot
This is an automated cherry-pick of pingcap#6226
a59d675 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2021
Closed
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6317.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #6226 on top of branch "release-5.0":

failed to git commit: exit status 1

This was referenced Jun 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

Assignees

@Liuxiaozhen12 Liuxiaozhen12

Labels
require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@youjiali1995 @TomShawn @cfzjywxk @ti-chi-bot @ti-srebot @Liuxiaozhen12