Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx typos in br external storages #6018

Merged
merged 9 commits into from
Apr 13, 2021
Merged

FIx typos in br external storages #6018

merged 9 commits into from
Apr 13, 2021

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Fix a few typos

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2021
@TomShawn
Copy link
Contributor Author

/assign
/cc @yikeke
/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation done
/label require-LGT1

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-4.0 labels Apr 12, 2021
@ti-chi-bot ti-chi-bot requested a review from yikeke April 12, 2021 07:40
@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 12, 2021
@TomShawn TomShawn mentioned this pull request Apr 12, 2021
Merged
10 tasks
@yikeke yikeke requested a review from IANTHEREAL April 12, 2021 07:46
@IANTHEREAL
Copy link
Contributor

LGTM

1 similar comment
@kennytm
Copy link
Contributor

kennytm commented Apr 12, 2021

LGTM

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2021
@TomShawn TomShawn mentioned this pull request Apr 12, 2021
Merged
10 tasks
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2021
yikeke
yikeke approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yikeke
Copy link
Contributor

yikeke commented Apr 13, 2021

/sig migration

@ti-chi-bot
Copy link
Member

@yikeke: The label(s) sig/migration cannot be applied, because the repository doesn't have them.

In response to this:

/sig migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yikeke
Copy link
Contributor

yikeke commented Apr 13, 2021

/sig migrate

@ti-chi-bot ti-chi-bot added the area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. label Apr 13, 2021
@YuJuncen
Copy link
Contributor

/lgtm

@yikeke yikeke removed the require-LGT1 Indicates that the PR requires an LGTM. label Apr 13, 2021
@YuJuncen
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2021
@yikeke
Copy link
Contributor

yikeke commented Apr 13, 2021

/merge

@ti-chi-bot
Copy link
Member

@yikeke: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YuJuncen
Copy link
Contributor

YuJuncen commented Apr 13, 2021 •
edited
Loading

/merge

Seems this PR was FULLY treated as a sig-migrate item...🧐

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3728810

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021
@ti-chi-bot ti-chi-bot merged commit 39dfbef into pingcap:master Apr 13, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 13, 2021
@TomShawn @ti-srebot
cherry pick pingcap#6018 to release-4.0
c424b4f 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #6024

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 13, 2021
@TomShawn @ti-srebot
cherry pick pingcap#6018 to release-5.0
8256167 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #6025

@TomShawn TomShawn deleted the fix-typosaaa branch April 13, 2021 05:00
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
FIx typos in br external storages (#6018) (#6025)
913a47a
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
FIx typos in br external storages (#6018) (#6024)
7f9ff96
@yikeke
Copy link
Contributor

yikeke commented Apr 13, 2021

/merge

Seems this PR was FULLY treated as a sig-migrate item...🧐

Solved. I need to add the sig/docs label as well...

This was referenced Apr 13, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@IANTHEREAL IANTHEREAL Awaiting requested review from IANTHEREAL

Assignees

@TomShawn TomShawn

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TomShawn @IANTHEREAL @kennytm @yikeke @ti-chi-bot @YuJuncen @ti-srebot