-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br:tidy up the incompatible issues in using BR tools. #5224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you inline backup-and-restore-incompatible.md
into the section ## 兼容性
?
Done, PTAL again |
/rebuild |
it seems irrelevant 🤔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
br/backup-and-restore-tool.md
Outdated
Cluster Index | [#565](https://github.com/pingcap/br/issues/565) | 确保备份时 cluster_index 和恢复时一致,否则会导致数据不一致的问题,如 default not found, 数据索引不一致。 | ||
New collation | [#352](https://github.com/pingcap/br/issues/352) | 确保备份时集群 new_collation 和恢复时一致,否则会导致数据索引不一致,checksum 不通过。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 如果 BR 和聚簇索引/ New collation 不兼容,为什么会有 "备份时 cluster_index /New collation 和恢复时一致”呢?似乎是说已经使用了这两个不兼容的功能,但不需要禁用?感觉有些困惑。
- Cluster Index --> Clustered Index 或 聚簇索引
- New collation 不等于 new_collation 吗?
br/backup-and-restore-tool.md
Outdated
| ---- | ---- | ----- | | ||
Cluster Index | [#565](https://github.com/pingcap/br/issues/565) | 确保备份时 cluster_index 和恢复时一致,否则会导致数据不一致的问题,如 default not found, 数据索引不一致。 | ||
New collation | [#352](https://github.com/pingcap/br/issues/352) | 确保备份时集群 new_collation 和恢复时一致,否则会导致数据索引不一致,checksum 不通过。 | ||
恢复集群开启 CDC 同步 | [#364](https://github.com/pingcap/br/issues/364#issuecomment-646813965) | BR ingest 的 SST 文件, TiKV 还没实现下推到 CDC,因此使用 BR 恢复时候需要关闭 CDC。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CDC --> TiCDC
br/backup-and-restore-tool.md
Outdated
New collation | [#352](https://github.com/pingcap/br/issues/352) | 确保备份时集群 new_collation 和恢复时一致,否则会导致数据索引不一致,checksum 不通过。 | ||
恢复集群开启 CDC 同步 | [#364](https://github.com/pingcap/br/issues/364#issuecomment-646813965) | BR ingest 的 SST 文件, TiKV 还没实现下推到 CDC,因此使用 BR 恢复时候需要关闭 CDC。 | ||
|
||
在上述 feature 确保兼容的**前提**下,BR 和 TiKV/TiDB/PD 还可能因为版本内部协议不一致/接口不一致出现不兼容的问题,因此 BR 内置了版本检查。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在上述 feature 确保兼容的前提下
,但上面三个 feature 似乎是不兼容的。这里写感觉有些前后矛盾。
### 版本检查 | ||
|
||
BR 内置版本检查会在执行前,对集群版本和自身版本进行对比检查,如果大版本对不上(比如 BR 4.x 用在 TiDB 5.x 上), 那么会提示退出。但是可以通过设置 `--check-requirements=false` 强行跳过版本检查。 | ||
需要注意的是,跳过检查可能会遇到版本不兼容的问题,现整理如下: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要简单介绍一下下表是什么。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里描述的是 BR 版本和 TiDB集群版本兼容信息整理
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里有描述
`BR 内置版本会在执行备份和恢复操作前,对 TiDB 集群版本和自身版本进行对比检查
`
br/backup-and-restore-tool.md
Outdated
BR 内置版本检查会在执行前,对集群版本和自身版本进行对比检查,如果大版本对不上(比如 BR 4.x 用在 TiDB 5.x 上), 那么会提示退出。但是可以通过设置 `--check-requirements=false` 强行跳过版本检查。 | ||
需要注意的是,跳过检查可能会遇到版本不兼容的问题,现整理如下: | ||
|
||
| 备份 \ 恢复| BR nightly / TiDB nightly| BR 5.0 / TiDB 5.0| BR 4.0 / TiDB 4.0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
br/backup-and-restore-tool.md
Outdated
| ---- | ---- | ---- | ---- | | ||
**BR nightly / TiDB nightly** | ✅ | ✅ | ✅ | | ||
**BR 5.0 / TiDB 5.0** | ✅ | ✅ | ✅ | ||
**BR 4.0 / TiDB 4.0** | ✅ | ✅ | ✅(TiKV>=4.0.0-rc.1(BR [#233](https://github.com/pingcap/br/pull/233) and TiKV not include [#7241](https://github.com/tikv/tikv/pull/7241)), BR will panic TiKV) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
中文文档请尽量使用中文叙述。
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: TomShawn <[email protected]>
Co-authored-by: TomShawn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Global comment: BR 4.0 或 5.0 --> BR v4.0 或 v5.0,TiDB 4.0 或 5.0 相同
Co-authored-by: TomShawn <[email protected]>
/label require-LGT1 |
/lgtm |
/remove-status require-change |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 169f3e3
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #5802 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #5803 |
/remove-translation doing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Tidy up the incompatible issues in using BR tools.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?