Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimizer-hints: add docs for nth_plan() hint #4227

Merged
merged 4 commits into from
Aug 24, 2020
Merged

optimizer-hints: add docs for nth_plan() hint #4227

merged 4 commits into from
Aug 24, 2020

Conversation

time-and-fate
Copy link
Member

What is changed, added or deleted? (Required)

Add dos for nth_plan() hint in /optimizer-hints.md.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Aug 7, 2020
@CLAassistant
Copy link

CLAassistant commented Aug 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@TomShawn TomShawn requested review from eurekaka and lzmhhh123 August 10, 2020 12:20
@TomShawn
Copy link
Contributor

@lzmhhh123 @eurekaka Please also help confirm whether this PR applies to v4.0, thanks!

@TomShawn TomShawn added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Aug 10, 2020
@TomShawn TomShawn self-requested a review August 10, 2020 12:21
eurekaka
eurekaka reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expose this hint to users? I believe this hint is just for testing purpose, users may have no expectation about what the result plan of nth_plan(xxx) would be? @SunRunAway

@ti-srebot
Copy link
Contributor

@eurekaka, @lzmhhh123, @TomShawn, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@eurekaka, @lzmhhh123, @TomShawn, PTAL.

@ti-srebot
Copy link
Contributor

@eurekaka, @lzmhhh123, @TomShawn, PTAL.

@SunRunAway
Copy link
Contributor

Should we expose this hint to users? I believe this hint is just for testing purpose, users may have no expectation about what the result plan of nth_plan(xxx) would be? @SunRunAway

I think it is ok to expose this to users, and we should state that it is for testing purposes and may not be compatible in the future.

@time-and-fate time-and-fate requested a review from eurekaka August 20, 2020 07:50
@TomShawn TomShawn added the v5.0 This PR/issue applies to TiDB v5.0 label Aug 20, 2020
@ti-srebot
Copy link
Contributor

@eurekaka, @lzmhhh123, @TomShawn, PTAL.

SunRunAway
SunRunAway reviewed Aug 24, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@SunRunAway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2020
@TomShawn TomShawn merged commit 837c2c6 into pingcap:master Aug 24, 2020
@yikeke yikeke assigned Joyinqin and unassigned ireneontheway Sep 1, 2020
@Joyinqin Joyinqin mentioned this pull request Sep 3, 2020
Merged
9 tasks
@Joyinqin
Copy link
Contributor

Joyinqin commented Sep 3, 2020

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Sep 3, 2020
@Joyinqin
Copy link
Contributor

Joyinqin commented Sep 3, 2020

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@TomShawn TomShawn TomShawn approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees

@Joyinqin Joyinqin

Labels
contribution This PR is from a community contributor. size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@time-and-fate @CLAassistant @TomShawn @ti-srebot @SunRunAway @Joyinqin @eurekaka @ireneontheway