Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add document for tiup-cluster #4066

Merged
merged 6 commits into from
Aug 4, 2020
Merged

Add document for tiup-cluster #4066

merged 6 commits into from
Aug 4, 2020

Conversation

lucklove
Copy link
Member

document for pingcap/tiup#615

Signed-off-by: lucklove [email protected]

What is changed, added or deleted? (Required)

Add document for tiup-cluster

We introduce a new feature which can use native ssh client now.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

lonng
lonng reviewed Jul 28, 2020
View reviewed changes
lonng
lonng reviewed Jul 28, 2020
View reviewed changes
lonng
lonng reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

july2993
july2993 reviewed Jul 28, 2020
View reviewed changes
tiup/tiup-cluster.md

也可以使用环境变量 `TIUP_NATIVE_SSH` 来指定是否使用本地 SSH 客户端，避免每个命令都需要添加 `--native-ssh` 参数：

```sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

写一个就好了

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

都写上吧。。。QA 测试也好参考一下

@lucklove
Address comment
d81f489 
Signed-off-by: lucklove <[email protected]>
@TomShawn TomShawn added needs-cherry-pick-4.0 size/medium Changes of a medium size. translation/doing This PR’s assignee is translating this PR. labels Jul 28, 2020
@TomShawn TomShawn self-assigned this Jul 28, 2020
TomShawn
TomShawn reviewed Jul 28, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2020
@lucklove
Copy link
Member Author

lucklove commented Aug 3, 2020

how to merge?

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2020
@ti-srebot
Copy link
Contributor

@TomShawn Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1.

@TomShawn TomShawn removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2020
@TomShawn TomShawn merged commit e3ecab0 into pingcap:master Aug 4, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 4, 2020
@lucklove @ti-srebot
cherry pick pingcap#4066 to release-4.0
513494c 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 4, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4182

TomShawn pushed a commit that referenced this pull request Aug 4, 2020
@ti-srebot @lucklove
cherry pick #4066 to release-4.0 (#4182)
29598ff 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: SIGSEGV <[email protected]>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 1, 2020
@TomShawn TomShawn mentioned this pull request Sep 1, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Sep 2, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonng lonng lonng left review comments

@july2993 july2993 july2993 left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucklove @ti-srebot @lonng @july2993 @TomShawn