Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference: add compatibility issue for STRING type #2134

Merged
merged 3 commits into from
Feb 21, 2020
Merged

reference: add compatibility issue for STRING type #2134

merged 3 commits into from
Feb 21, 2020
+21 −3

Conversation

winoros
Copy link
Member

@winoros winoros commented Dec 23, 2019 •
edited by lilin90
Loading

What is changed, added or deleted?

Add compatibility issue.

What is the related PR or file link(s)?

pingcap/tidb#14007 This pr changed the bahavior when compare or scan STRING data. So we need to update the docs too.

Which version does your change affect?

dev, v3.0, v3.1

@lilin90 lilin90 requested a review from TomShawn December 27, 2019 12:07
@lilin90 lilin90 added size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Dec 27, 2019
TomShawn
TomShawn reviewed Jan 2, 2020
View reviewed changes
dev/reference/mysql-compatibility.md Outdated Show resolved Hide resolved
dev/reference/mysql-compatibility.md Outdated Show resolved Hide resolved
dev/reference/mysql-compatibility.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 changed the title dev, v3.0: add compatibility issue for STRING type reference: add compatibility issue for STRING type Feb 21, 2020
@lilin90 lilin90 merged commit 2a98c4d into pingcap:master Feb 21, 2020
@yikeke yikeke added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 12, 2020
@yikeke yikeke added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Mar 23, 2020
@lilin90 lilin90 added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 24, 2020
@lilin90 lilin90 added translation/doing This PR’s assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Mar 24, 2020
@yikeke yikeke added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 25, 2020
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Mar 25, 2020
@sumens sumens mentioned this pull request Mar 25, 2020
Merged
4 tasks
@sre-bot sre-bot mentioned this pull request Apr 13, 2020
Merged
4 tasks
This was referenced Apr 13, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winoros @lilin90 @TomShawn @toutdesuite @yikeke