Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add document for items which will be removed #1909

Merged
merged 4 commits into from
Oct 10, 2019
Merged

config: add document for items which will be removed #1909

merged 4 commits into from
Oct 10, 2019

Conversation

lucklove
Copy link
Member

Signed-off-by: lucklove [email protected]

What is changed, added or deleted?

Some config items will be removed from tidb-ansible template, in case no one knows them in
the future, we should document them.

What is the related PR or file link(s)?

pingcap/tidb-ansible#978

Which version does your change affect?

3.0 and dev

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Oct 8, 2019
@lilin90 lilin90 requested a review from dcalvin October 8, 2019 03:08
dcalvin
dcalvin reviewed Oct 8, 2019
View reviewed changes
dev/reference/configuration/tikv-server/configuration-file.md Outdated
### `ca-path`

+ CA 文件路径
+ 默认：""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be consistent in the use of “默认” and “默认值” in the same file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@dcalvin dcalvin added aligning and removed translation/doing This PR’s assignee is translating this PR. labels Oct 8, 2019
@dcalvin dcalvin mentioned this pull request Oct 8, 2019
Merged
@dcalvin dcalvin added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed aligning labels Oct 8, 2019
@ericsyh
Copy link
Member

ericsyh commented Oct 8, 2019

LGTM

@lilin90
Copy link
Member

lilin90 commented Oct 8, 2019 •
edited
Loading

@lucklove

  • Still inconsistent among different files.
  • Please sign the CLA.
  • Please DO NOT directly create branches in the upstream repo. Fork this repo first.

@lucklove
Copy link
Member Author

lucklove commented Oct 8, 2019

  • Still inconsistent among different files.
    I notice that pd use different word compare with tidb and tikv, but it's not caused by this PR, it should be fixed in another pull request.

@lilin90
Copy link
Member

lilin90 commented Oct 9, 2019

@dcalvin PTAL

@dcalvin
Copy link
Contributor

dcalvin commented Oct 9, 2019

LGTM. Agree that we may need to fix the inconsistency in another PR.

dcalvin
dcalvin approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 1252c2a into master Oct 10, 2019
@lilin90 lilin90 deleted the add-items-for-config-file branch October 10, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalvin dcalvin dcalvin approved these changes

Assignees

@dcalvin dcalvin

Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucklove @CLAassistant @ericsyh @lilin90 @dcalvin