Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dev-java-mybatis #16169

Merged
merged 2 commits into from
Jan 24, 2024
Merged

update dev-java-mybatis #16169

merged 2 commits into from
Jan 24, 2024

Conversation

Weaxs
Copy link
Contributor

@Weaxs Weaxs commented Jan 12, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

FIX #15776

  1. 对了点简单的格式化,主要是对xml 中的SQL关键字和变量进行了大写
  2. 示例代码片段只有mapper xml,补了一下对应的接口和函数

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 12, 2024
@rpaik rpaik added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Jan 12, 2024
@qiancai qiancai requested a review from Icemap January 12, 2024 05:26
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Jan 12, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 12, 2024
@Icemap
Copy link
Member

Icemap commented Jan 15, 2024

文档中已提到 配置的接口类中添加同名函数 了,接口的增加会显得冗余,且增长文档篇幅。

@Weaxs
Copy link
Contributor Author

Weaxs commented Jan 15, 2024

文档中已提到 配置的接口类中添加同名函数 了,接口的增加会显得冗余,且增长文档篇幅。

好的 我去一下

Copy link
Member

@Icemap Icemap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 15, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2024
Copy link

ti-chi-bot bot commented Jan 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-15 09:55:07.544991331 +0000 UTC m=+176949.109289020: ☑️ agreed by Icemap.
  • 2024-01-24 12:03:25.782256802 +0000 UTC m=+962247.346554508: ☑️ agreed by qiancai.

@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 24, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jan 24, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 24, 2024
@ti-chi-bot ti-chi-bot bot merged commit b3391d4 into pingcap:master Jan 24, 2024
4 of 5 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #16300.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16301.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 24, 2024
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16302.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16303.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 24, 2024
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16304.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #16305.

ti-chi-bot bot pushed a commit that referenced this pull request Jan 24, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 24, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 24, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 24, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 24, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR.
Development

Successfully merging this pull request may close these issues.

Debug TiDB Documentation: 使用 MyBatis 连接到 TiDB
5 participants