tiup: add additional_args #16114
tiup: add additional_args #16114
Conversation
ti-chi-bot
bot
added
contribution
Oreoxmt
added
needs-cherry-pick-release-6.5
|
/cc @srstack |
ti-chi-bot
bot
removed
the
missing-translation-status
| @@ -554,6 +554,7 @@ tispark_workers: | |||
| - `os`：`host` 字段所指定的机器的操作系统，若不指定该字段，则默认为 `global` 中的 `os` | |||
| - `arch`：`host` 字段所指定的机器的架构，若不指定该字段，则默认为 `global` 中的 `arch` | |||
| - `resource_control`：针对该服务的资源控制，如果配置了该字段，会将该字段和 `global` 中的 `resource_control` 内容合并（若字段重叠，以本字段内容为准），然后生成 systemd 配置文件并下发到 `host` 指定机器。`resource_control` 的配置规则同 `global` 中的 `resource_control` | |||
| - `additional_args`：配置额外的 Prometheus Args 参数。该字段为一个数组，数组元素为 Prometheus 运行参数。例如：开启 Prometheus 热加载配置，配置 `--web.enable-lifecycle` 即可 | |||
There was a problem hiding this comment.
这个参数虽然merge 到 tiup master 代码了 (pingcap/tiup#2340) ，但鉴于 tiup 未发版，目前终端用户无法直接用到这个参数，建议待包含相关代码的tiup发版后再增加这段文档，最好再标注下从tiup v？开始可以使用
There was a problem hiding this comment.
这个 PR 可以晚点合并。后续的 tiup 发版，我补充下 tiup 版本信息吧。
There was a problem hiding this comment.
这个 PR 应该会合并到 tiup 1.15.0 这个版本
Oreoxmt
added
the
do-not-merge/hold
|
I will merge this PR once TiUP v1.15.0 has been released. |
[LGTM Timeline notifier]Timeline:
|
|
When can this be merged? Or do you need me to do something here? @Oreoxmt |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?