Add docs for TiCDC support checking if data is entirely replicated to Downstream
#15766
Conversation
ti-chi-bot
bot
added
missing-translation-status
|
/cc @flowbehappy |
qiancai
added
translation/doing
ti-chi-bot
bot
removed
the
missing-translation-status
ticdc/ticdc-open-api-v2.md
Outdated
| } | ||
| ``` | ||
|
|
||
| 该示例展示的是并未严格的完成同步任务时返回的查询结果，我们可以结合 `synced` 和 `info` 字段确认数据目前同步的状态。 |
There was a problem hiding this comment.
建议在每一个示例后面分别加一个解释。上面分成 3 个示例
ticdc/ticdc-open-api-v2.md
Outdated
| "puller_resolved_ts":"2023-12-13 11:45:13", | ||
| "last_synced_ts":"2023-12-13 11:45:07", | ||
| "now_ts":"2023-12-13 11:47:24", | ||
| "info":"Please check whether pd is health and tikv region is all available. If pd is not health or tikv region is not available, the data syncing is finished. Otherwise the data syncing is not finished, please wait" |
There was a problem hiding this comment.
“the data syncing is finished” 后面补一下判断条件
There was a problem hiding this comment.
这个是说我需要解释一下为什么 pd 或者 tikv unavailable 的时候，我们判断 data syncing is finished 嘛？
There was a problem hiding this comment.
我这边补充了一些解释，麻烦看看这样可以么
ticdc/ticdc-open-api-v2.md
Outdated
| "puller_resolved_ts":"2023-12-13 11:45:13", | ||
| "last_synced_ts":"2023-12-13 11:45:07", | ||
| "now_ts":"2023-12-13 11:47:24", | ||
| "info":"Please check whether pd is health and tikv region is all available. If pd is not health or tikv region is not available, the data syncing is finished. Otherwise the data syncing is not finished, please wait" |
There was a problem hiding this comment.
I would suggest changing "health" to "healthy" in this text as it is being used as an adjective.
There was a problem hiding this comment.
Good Point! I will change it to "healthy"
Co-authored-by: Flowyi <[email protected]>
|
@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Grace Cai <[email protected]>
ti-chi-bot
bot
removed
the
size/M
qiancai
added
translation/done
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oreoxmt
added
the
needs-cherry-pick-release-6.5
|
In response to a cherrypick label: new pull request created to branch |
qiancai
added
needs-cherry-pick-release-7.1
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
pingcap/tiflow#10133
Do your changes match any of the following descriptions?