Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: add ticdc sql mode config #15361

Merged
merged 4 commits into from
Nov 13, 2023
Merged

cdc: add ticdc sql mode config #15361

merged 4 commits into from
Nov 13, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Nov 2, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2023
@ran-huang ran-huang added v7.5 This PR/issue applies to TiDB v7.5. translation/doing This PR’s assignee is translating this PR. labels Nov 2, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 2, 2023
@ran-huang ran-huang self-assigned this Nov 2, 2023
@ran-huang ran-huang self-requested a review November 2, 2023 06:02
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 2, 2023

@CharlesCheung96: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 2, 2023

@sdojjy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 2, 2023

@nongfushanquan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ran-huang
ran-huang reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ran-huang ran-huang mentioned this pull request Nov 2, 2023
Merged
17 tasks
@ran-huang ran-huang changed the title add ticdc sql mode config cdc: add ticdc sql mode config Nov 2, 2023
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 2, 2023
@Oreoxmt Oreoxmt added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Nov 3, 2023
@Oreoxmt Oreoxmt self-requested a review November 7, 2023 02:19
Oreoxmt
Oreoxmt approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 7, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-07 03:15:56.79388373 +0000 UTC m=+3527754.380993876: ☑️ agreed by Oreoxmt.

@ran-huang ran-huang added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Nov 7, 2023
@ran-huang
Copy link
Contributor

/approve

@ran-huang ran-huang added the lgtm label Nov 13, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 966f17b into pingcap:master Nov 13, 2023
@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Dec 25, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 25, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15886.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 25, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15887.

This was referenced Dec 25, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 25, 2023
@ti-chi-bot
v7.1.3 cdc: add ticdc sql mode config (#15361) (#15887)
e83a043
ti-chi-bot bot pushed a commit that referenced this pull request Dec 25, 2023
@ti-chi-bot
v6.5.6: cdc: add ticdc sql mode config (#15361) (#15886)
f8b596c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@sdojjy sdojjy sdojjy approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

Assignees

@ran-huang ran-huang

Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.5 This PR/issue applies to TiDB v7.5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@asddongmen @ran-huang @ti-chi-bot @sdojjy @Oreoxmt @CharlesCheung96 @nongfushanquan @qiancai