Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd: bugfix for the descriptions on Slow Score. #14310

Merged
merged 1 commit into from
Jun 30, 2023
Merged

pd: bugfix for the descriptions on Slow Score. #14310

merged 1 commit into from
Jun 30, 2023

Conversation

LykxSassinator
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Bugfix for the description on Slow Score part.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2023
@LykxSassinator
Copy link
Contributor Author

@ran-huang PTAL, thx

@LykxSassinator
Copy link
Contributor Author

/cc @qiancai

@ti-chi-bot ti-chi-bot bot requested a review from qiancai June 26, 2023 02:51
qiancai
qiancai approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 26, 2023
@qiancai qiancai requested a review from rleungx June 26, 2023 03:17
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 26, 2023
@qiancai qiancai added ONCALL Relates to documentation oncall. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 26, 2023
@qiancai qiancai self-assigned this Jun 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-26 03:17:23.559215749 +0000 UTC m=+591208.960466183: ☑️ agreed by qiancai.
  • 2023-06-26 05:30:04.562971168 +0000 UTC m=+599169.964221604: ☑️ agreed by ran-huang.

@qiancai qiancai added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-7.2 and removed translation/doing This PR’s assignee is translating this PR. labels Jun 26, 2023
@qiancai
Copy link
Collaborator

qiancai commented Jun 30, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0bf5e0c into pingcap:master Jun 30, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 30, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14384.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #14385.

This was referenced Jun 30, 2023
Closed
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #14386.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 30, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14387.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 30, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14388.

@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/from-docs This PR is translated from a PR in pingcap/docs. labels Jul 10, 2023
@qiancai qiancai mentioned this pull request Jul 7, 2023
Merged
17 tasks
This was referenced Jul 10, 2023
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jul 11, 2023
@ti-chi-bot
pd: bugfix for the descriptions on Slow Score. (#14310) (#14387)
53c0370
ti-chi-bot bot pushed a commit that referenced this pull request Jul 11, 2023
@ti-chi-bot
pd: bugfix for the descriptions on Slow Score. (#14310) (#14388)
abfc595
ti-chi-bot bot pushed a commit that referenced this pull request Jul 11, 2023
@ti-chi-bot
pd: bugfix for the descriptions on Slow Score. (#14310) (#14384)
eadf5f6
ti-chi-bot bot pushed a commit that referenced this pull request Jul 11, 2023
@ti-chi-bot
pd: bugfix for the descriptions on Slow Score. (#14310) (#14386)
d4ee782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@ran-huang ran-huang ran-huang approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LykxSassinator @qiancai @ti-chi-bot @rleungx @ran-huang