Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: add load data doc #13344

Merged
merged 73 commits into from
Mar 27, 2023
Merged

lightning: add load data doc #13344

merged 73 commits into from
Mar 27, 2023

Conversation

D3Hunter
Copy link
Collaborator

@D3Hunter D3Hunter commented Mar 9, 2023 •
edited by hfxsd
Loading

What is changed, added or deleted? (Required)

Added LOAD DATA doc.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2023
@ti-chi-bot ti-chi-bot requested a review from TomShawn March 9, 2023 10:22
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2023
@hfxsd hfxsd self-requested a review March 9, 2023 13:40
@hfxsd hfxsd self-assigned this Mar 9, 2023
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. v7.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 9, 2023
@lance6716 lance6716 mentioned this pull request Mar 13, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2023
@D3Hunter D3Hunter marked this pull request as ready for review March 17, 2023 07:47
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2023
@D3Hunter
Copy link
Collaborator Author

@lance6716 @francis0407 ptal

lance6716
lance6716 reviewed Mar 17, 2023
View reviewed changes
D3Hunter
D3Hunter commented Mar 24, 2023
View reviewed changes
hfxsd
hfxsd reviewed Mar 24, 2023
View reviewed changes
qiancai
qiancai reviewed Mar 24, 2023
View reviewed changes
qiancai
qiancai reviewed Mar 24, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2023
qiancai
qiancai approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM

@hfxsd
Copy link
Collaborator

hfxsd commented Mar 27, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 19cf43b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2023
@ti-chi-bot ti-chi-bot merged commit 78873af into master Mar 27, 2023
@ran-huang ran-huang deleted the load-data-doc branch March 28, 2023 04:05
@Frank945946 Frank945946 mentioned this pull request Apr 11, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@Frank945946 Frank945946 Frank945946 approved these changes

Assignees

@hfxsd hfxsd

Labels
area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@D3Hunter @ti-chi-bot @hfxsd @lance6716 @qiancai @Frank945946