Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-infra: document for resource control feature #12655

Merged
merged 120 commits into from
Feb 17, 2023
Merged

sql-infra: document for resource control feature #12655

merged 120 commits into from
Feb 17, 2023

Conversation

BornChanger
Copy link
Contributor

Signed-off-by: BornChanger [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add documentation for resource control feature.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn January 12, 2023 14:37
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 12, 2023
@BornChanger
Copy link
Contributor Author

/cc @nolouch @glorv @kevin-xianliu @songrijie PLTA

@ti-chi-bot
Copy link
Member

@BornChanger: GitHub didn't allow me to request PR reviews from the following users: kevin-xianliu, PLTA.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @nolouch @glorv @kevin-xianliu @songrijie PLTA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/cc @hfxsd PTAL

@ti-chi-bot ti-chi-bot requested a review from hfxsd January 12, 2023 14:47
@ti-chi-bot
Copy link
Member

@BornChanger: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @hfxsd PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger BornChanger force-pushed the resource_control branch 2 times, most recently from 84a997f to 9edc011 Compare January 12, 2023 16:15
@BornChanger
*: minor adjustment
9c82cf6 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
Copy link
Contributor Author

/cc @kevin-xianliu

@ti-chi-bot
Copy link
Member

@BornChanger: GitHub didn't allow me to request PR reviews from the following users: kevin-xianliu.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kevin-xianliu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hfxsd
hfxsd reviewed Jan 13, 2023
View reviewed changes
sql-statements/sql-statement-alter-resource-group.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-resource-group.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-create-resource-group.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jan 13, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Feb 16, 2023
View reviewed changes
grafana-resource-control-dashboard.md Outdated Show resolved Hide resolved
grafana-resource-control-dashboard.md Outdated Show resolved Hide resolved
information-schema/information-schema-resource-groups.md Outdated

`RESOURCE_GROUPS` 表展示所有资源组 (resource group) 的信息，见[使用资源管控 (Resource Control) 实现资源隔离](/tidb-resource-control.md)。

{{< copyable "sql" >}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyable 这样目前不再需要了，文档站会为所有代码块加上复制按钮

information-schema/information-schema-resource-groups.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-resource-group.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Feb 17, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Feb 17, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hfxsd
hfxsd reviewed Feb 17, 2023
View reviewed changes
grafana-tikv-dashboard.md Outdated Show resolved Hide resolved
@shichun-0415
Copy link
Contributor

/verify

@hfxsd
Copy link
Collaborator

hfxsd commented Feb 17, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0015425

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 17, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 17, 2023
@hfxsd
Copy link
Collaborator

hfxsd commented Feb 17, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0a15cc1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 17, 2023
@ti-chi-bot ti-chi-bot merged commit a4ff65c into pingcap:master Feb 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 17, 2023
Merged
14 tasks
@lilin90 lilin90 mentioned this pull request Mar 29, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@CabinfeverB CabinfeverB CabinfeverB left review comments

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 left review comments

@dveeden dveeden dveeden left review comments

@Connor1996 Connor1996 Connor1996 left review comments

@HuSharp HuSharp HuSharp left review comments

@winkyao winkyao winkyao left review comments

@nolouch nolouch nolouch left review comments

@glorv glorv glorv left review comments

@shichun-0415 shichun-0415 shichun-0415 left review comments

@kevin-xianliu kevin-xianliu kevin-xianliu left review comments

@TomShawn TomShawn TomShawn left review comments

@shawn0915 shawn0915 shawn0915 left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@JmPotato JmPotato JmPotato approved these changes

@qiancai qiancai qiancai approved these changes

@songrijie songrijie songrijie approved these changes

Assignees

@hfxsd hfxsd

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.