Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add content about nt-dml for insert and update #12079

Merged
merged 15 commits into from
Dec 6, 2022
Merged

add content about nt-dml for insert and update #12079

merged 15 commits into from
Dec 6, 2022

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Nov 21, 2022

Signed-off-by: ekexium [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ekexium ekexium requested a review from Oreoxmt November 21, 2022 15:56
@ti-chi-bot ti-chi-bot requested a review from TomShawn November 21, 2022 15:56
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2022
@ekexium ekexium requested a review from you06 November 21, 2022 16:00
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2022
@Oreoxmt Oreoxmt added v6.5 This PR/issue applies to TiDB v6.5. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 21, 2022
@Oreoxmt Oreoxmt self-assigned this Nov 23, 2022
Oreoxmt
Oreoxmt reviewed Nov 23, 2022
View reviewed changes
@Oreoxmt Oreoxmt self-requested a review November 23, 2022 08:42
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 24, 2022

@you06 PTAL

you06
you06 approved these changes Nov 25, 2022
View reviewed changes
@ekexium @Oreoxmt @you06
Apply suggestions from code review
19972c0 
Co-authored-by: Aolin <[email protected]>
Co-authored-by: you06 <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 28, 2022
@ekexium
fix typo
4bb35f3 
Signed-off-by: ekexium <[email protected]>
Oreoxmt
Oreoxmt reviewed Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@Oreoxmt Oreoxmt self-requested a review November 28, 2022 05:35
Oreoxmt
Oreoxmt reviewed Nov 28, 2022
View reviewed changes
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 28, 2022
@Oreoxmt Oreoxmt mentioned this pull request Nov 28, 2022
Merged
14 tasks
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 2, 2022

@SunRunAway PTAL

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 2, 2022

/verify

Oreoxmt
Oreoxmt reviewed Dec 2, 2022
View reviewed changes
SunRunAway
SunRunAway reviewed Dec 2, 2022
View reviewed changes
SunRunAway
SunRunAway reviewed Dec 2, 2022
View reviewed changes
@Oreoxmt Oreoxmt requested a review from SunRunAway December 2, 2022 03:54
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2022
@Oreoxmt Oreoxmt requested a review from TomShawn December 2, 2022 04:43
Oreoxmt
Oreoxmt reviewed Dec 2, 2022
View reviewed changes
SunRunAway
SunRunAway reviewed Dec 2, 2022
View reviewed changes
Oreoxmt
Oreoxmt reviewed Dec 2, 2022
View reviewed changes
Oreoxmt
Oreoxmt approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bff58aa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2022
@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 5, 2022
@ti-chi-bot ti-chi-bot merged commit 57ca5f5 into pingcap:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@you06 you06 you06 approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.5 This PR/issue applies to TiDB v6.5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ekexium @ti-chi-bot @Oreoxmt @SunRunAway @you06 @TomShawn