Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: update get started doc #12059

Merged
merged 4 commits into from
Dec 14, 2023
Merged

lightning: update get started doc #12059

merged 4 commits into from
Dec 14, 2023

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Nov 18, 2022 •
edited by Oreoxmt
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2022
@ti-chi-bot ti-chi-bot requested a review from TomShawn November 18, 2022 07:30
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2022
@ran-huang ran-huang marked this pull request as ready for review November 18, 2022 07:33
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2022
@ran-huang ran-huang added ONCALL Relates to documentation oncall. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. translation/doing This PR’s assignee is translating this PR. labels Nov 18, 2022
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Nov 18, 2022
@ran-huang ran-huang added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.3 labels Nov 18, 2022
@ran-huang ran-huang requested review from shichun-0415 and dsdashun and removed request for TomShawn November 18, 2022 07:34
dsdashun
dsdashun reviewed Nov 18, 2022
View reviewed changes
get-started-with-tidb-lightning.md Outdated
tiup dumpling -h 127.0.0.1 -P 3306 -u root -t 16 -F 256MB -B test -f 'test.t[12]' -o /data/my_database/
```
```shell
curl --proto '=https' --tlsv1.2 -sSf https://tiup-mirrors.pingcap.com/install.sh | sh && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command is to install TiUP, right ?
Maybe you can make it as a separate step to verify whether TiUP is installed. If not , use curl --proto '=https' --tlsv1.2 -sSf https://tiup-mirrors.pingcap.com/install.sh | sh to install the TiUP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 66194be

@ran-huang
address comments
66194be 
Signed-off-by: Ran <[email protected]>
@ran-huang ran-huang removed the missing-translation-status This PR does not have translation status info. label Nov 25, 2022
@ran-huang ran-huang self-assigned this Nov 25, 2022
@ran-huang ran-huang requested a review from dsdashun November 25, 2022 03:03
@ran-huang ran-huang added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 29, 2022
@qiancai
Copy link
Collaborator

qiancai commented Feb 24, 2023

Removed the needs-cherry-pick-release-6.3 label because the v6.3 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v6.3 and will no longer receive new updates.

@qiancai
Copy link
Collaborator

qiancai commented Apr 6, 2023

Removed the needs-cherry-pick-release-6.4 label because the v6.4 docs have been archived at https://docs-archive.pingcap.com/zh/tidb/v6.4 and will no longer receive new updates.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2023
Merged
14 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 14, 2023
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#12059
642c9ed 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #15748.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2023
Merged
14 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 14, 2023
@ran-huang @ti-chi-bot
This is an automated cherry-pick of pingcap#12059
216f280 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 14, 2023
@ti-chi-bot
lightning: update get started doc (#12059) (#15743)
fc83b43
ti-chi-bot bot pushed a commit that referenced this pull request Dec 14, 2023
@ti-chi-bot
lightning: update get started doc (#12059) (#15748)
900e5ce
ti-chi-bot bot pushed a commit that referenced this pull request Dec 14, 2023
@ti-chi-bot
lightning: update get started doc (#12059) (#15745)
2991fb3
ti-chi-bot bot pushed a commit that referenced this pull request Dec 14, 2023
@ti-chi-bot
lightning: update get started doc (#12059) (#15744)
92778e7
ti-chi-bot bot pushed a commit that referenced this pull request Dec 14, 2023
@ti-chi-bot
lightning: update get started doc (#12059) (#15746)
beb0528
ti-chi-bot bot pushed a commit that referenced this pull request Dec 14, 2023
@ti-chi-bot
lightning: update get started doc (#12059) (#15747)
ee3c1ed
@qiancai qiancai added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Dec 27, 2023
@qiancai qiancai added the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Dec 27, 2023
@TinaZhuzhu
Copy link

/assign

@rpaik
Copy link
Member

rpaik commented Jan 10, 2024

👋 @TinaZhuzhu, just a friendly reminder to submit your PR for TiDB Docs Dash by January 12 at 07:59 UTC. 🙏

Please reach out if you have any questions or need any help.

@TinaZhuzhu TinaZhuzhu mentioned this pull request Jan 12, 2024
Merged
18 tasks
@TinaZhuzhu
Copy link

/translation done

@ti-chi-bot ti-chi-bot bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jan 12, 2024
@TinaZhuzhu
Copy link

/remove-translation welcome

@ti-chi-bot ti-chi-bot bot removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jan 12, 2024
@ran-huang ran-huang removed the translation/doing This PR’s assignee is translating this PR. label Jan 22, 2024
This was referenced Jan 31, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsdashun dsdashun dsdashun left review comments

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@Frank945946 Frank945946 Frank945946 approved these changes

Assignees

@TinaZhuzhu TinaZhuzhu

Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. approved area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ONCALL Relates to documentation oncall. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
2024 TiDB Docs Dash Issue List | 2024 TiDB 文档挑战赛任务列表
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ran-huang @ti-chi-bot @qiancai @TinaZhuzhu @rpaik @dsdashun @Oreoxmt @Frank945946