Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add the doc for the SEMI_JOIN_REWRITE hint #10607

Merged
merged 7 commits into from
Jul 28, 2022
Merged

planner: add the doc for the SEMI_JOIN_REWRITE hint #10607

merged 7 commits into from
Jul 28, 2022

Conversation

winoros
Copy link
Member

@winoros winoros commented Jul 20, 2022 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add the doc about the new hint.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 20, 2022 10:12
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2022
@TomShawn TomShawn self-assigned this Jul 21, 2022
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. v6.2 This PR/issue applies to TiDB v6.2. status/PTAL This PR is ready for reviewing. and removed missing-translation-status This PR does not have translation status info. labels Jul 21, 2022
AilinKid
AilinKid approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomShawn
TomShawn reviewed Jul 22, 2022
View reviewed changes
TomShawn
TomShawn reviewed Jul 22, 2022
View reviewed changes
TomShawn
TomShawn reviewed Jul 22, 2022
View reviewed changes
@Oreoxmt Oreoxmt self-requested a review July 27, 2022 04:45
TomShawn
TomShawn approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 27, 2022
@TomShawn TomShawn mentioned this pull request Jul 27, 2022
Merged
12 tasks
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 27, 2022
Oreoxmt
Oreoxmt reviewed Jul 27, 2022
View reviewed changes
Oreoxmt
Oreoxmt approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 703124d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2022
@ti-chi-bot ti-chi-bot merged commit 4d6cd20 into pingcap:master Jul 28, 2022
@chrysan chrysan added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Aug 23, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 23, 2022
Open
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@TomShawn TomShawn TomShawn approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@TomShawn TomShawn

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@winoros @ti-chi-bot @TomShawn @AilinKid @time-and-fate @Oreoxmt @chrysan