-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
Codecov Report
@@ Coverage Diff @@
## release-1.0 #597 +/- ##
===================================================
- Coverage 57.2752% 57.2665% -0.0087%
===================================================
Files 161 161
Lines 16721 16741 +20
===================================================
+ Hits 9577 9587 +10
- Misses 6200 6206 +6
- Partials 944 948 +4 |
/run-all-tests |
@WangXiangUSTC @lichunzhu PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that we have too many debug log, if we are debug other issue and need to enable debug log, these logs may disturb us.
rest LGTM
em... but these logs are still needed for debug (or just let them as the placeholder). maybe when debugging, we can choose to?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
OK,LGTM |
What problem does this PR solve?
improve binlog replication performance in some cases.
What is changed and how it works?
null
value as the concurrence dispatch keyqueue-size
from5120
to1024
checkpoint-flush-interval
config itembinlogSkippedEventsTotal
toskipBinlogDurationHistogram
to support observe duration and update the Grafana dashboardCheck List
Tests
Code changes
Side effects
Related changes
dm/dm-ansible