Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

support json type for mysql downstream #2288

Merged
merged 2 commits into from
Dec 24, 2021

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

as title

What is changed and how it works?

change go-mysql to store json as string and update dependency version

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the dm/dm-ansible
  • Need to be included in the release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Dec 23, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Dec 23, 2021
@D3Hunter
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot added size/S and removed size/XS labels Dec 23, 2021
@lance6716
Copy link
Collaborator

lance6716 commented Dec 23, 2021

@glorv
Copy link
Collaborator

glorv commented Dec 24, 2021

Due to the outdated ci scripts, we will force merge this PR.

@glorv glorv merged commit 574ba60 into pingcap:release-2.0.7 Dec 24, 2021
@D3Hunter D3Hunter deleted the hot-fix-mysql-json branch December 24, 2021 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants