Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

log: fix NaN and Dpanic log #1201

Merged
merged 3 commits into from
Oct 22, 2020
Merged

log: fix NaN and Dpanic log #1201

merged 3 commits into from
Oct 22, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Oct 22, 2020

What problem does this PR solve?

  • loader progress show NaN % if no data in all tables
  • syncer log Dpanic when create database

Check List

Tests

  • Integration test

@GMHDBJD GMHDBJD added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 22, 2020
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Oct 22, 2020

/run-all-tests

csuzhangxc
csuzhangxc reviewed Oct 22, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 22, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 milestone Oct 22, 2020
lance6716
lance6716 approved these changes Oct 22, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc merged commit 443ae27 into pingcap:master Oct 22, 2020
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Oct 22, 2020
@GMHDBJD @ti-srebot
cherry pick pingcap#1201 to release-2.0
1acd7ff 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 22, 2020
Closed
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1207

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 22, 2020
GMHDBJD added a commit to GMHDBJD/dm that referenced this pull request Oct 23, 2020
@GMHDBJD
log: fix NaN and Dpanic log pingcap#1201
153dd2a
@GMHDBJD GMHDBJD mentioned this pull request Oct 23, 2020
Merged
csuzhangxc pushed a commit that referenced this pull request Oct 23, 2020
@GMHDBJD
log: fix NaN and Dpanic log #1201 (#1209)
3701751
@lance6716 lance6716 mentioned this pull request Sep 13, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GMHDBJD @ti-srebot @lance6716 @csuzhangxc