Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

fix: accept comands with leading and trailing white spaces #1200

Merged
merged 1 commit into from
Oct 22, 2020
Merged

fix: accept comands with leading and trailing white spaces #1200

merged 1 commit into from
Oct 22, 2020

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

exit with trailing white spaces

» exit
Error: unknown command "exit" for "dmctl"
Run 'dmctl --help' for usage.
fail to run: [exit]

exit with leading white spaces

»  exit
Error: unknown command "exit" for "dmctl"
Run 'dmctl --help' for usage.
fail to run: [exit]

What is changed and how it works?

remove leading and trailing white spaces before handling it.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • re-run commands above

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc csuzhangxc added priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 22, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 milestone Oct 22, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Oct 22, 2020
GMHDBJD
GMHDBJD approved these changes Oct 22, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 22, 2020
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Oct 22, 2020

/run-all-tests

@csuzhangxc csuzhangxc merged commit bccee94 into pingcap:master Oct 22, 2020
@csuzhangxc csuzhangxc deleted the fix-exit-space branch October 22, 2020 08:51
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Oct 22, 2020
@csuzhangxc @ti-srebot
cherry pick pingcap#1200 to release-2.0
5add178 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 22, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1202

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 22, 2020
csuzhangxc added a commit that referenced this pull request Oct 22, 2020
@ti-srebot @csuzhangxc
fix: accept comands with leading and trailing white spaces (#1200)
f0f5267 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Xuecheng Zhang <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@csuzhangxc @lance6716 @GMHDBJD @ti-srebot