This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
pkg/lightning: make save file checkpoint more compatible to avoid checkpoint data loss (#885) #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #885 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/889
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Currently, lightning use
ioutil.WriteFile
to save checkpoint file, which can lead to data loss if lightning exit before the file is fully writen.What is changed and how it works?
First write checkpoint content to a temp file and then replace it to the target file.
Check List
Tests
Code changes
Side effects
Related changes
Release Note