This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 101
pkg/lightning: replace local generated ts with tso fetch from pd #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM for now.
i don't particularly like requiring TS for TiDB backend, but let's refactor this later.
kennytm
reviewed
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
ti-srebot
approved these changes
Mar 12, 2021
/merge |
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Mar 12, 2021
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #860 |
ti-srebot
added a commit
that referenced
this pull request
Mar 12, 2021
… (#860) Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Replace commit ts generated with local time by tso fetch from pd. This can address the issue that if local time is mush faster than tidb cluster time, after import data with local/importer backend, query may returns empty result.
What is changed and how it works?
RestoreController
and use this ts for allWriteRows
Check List
Tests
Code changes
Side effects
Related changes
Release Note