This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
storage: fix s3 storage walk-dir with empty sub-dir (#713) #733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #713 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/733
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Close #712
What is changed and how it works?
The s3 implement
ListObjects
will return no data if set the prefix to/
instead of leave it empty.NOTE: the current implementation is compatible with
minio
but nos3
.Check List
Tests
Code changes
Side effects
Related changes
Release Note
WalkDir
for s3 storage returns nil if the target path is bucket name.