This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
restore: merge small ranges #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overvenus
force-pushed
the
debug-optimize-backupmeta
branch
from
4a34de6 to
dd32d46
Compare
|
/release |
Signed-off-by: Neil Shen <[email protected]>
overvenus
force-pushed
the
debug-optimize-backupmeta
branch
from
dd32d46 to
fa4d3a1
Compare
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
kennytm
reviewed
Nov 23, 2020
Signed-off-by: Neil Shen <[email protected]>
|
/rebuild |
kennytm
reviewed
Nov 25, 2020
Signed-off-by: Neil Shen <[email protected]>
kennytm
reviewed
Nov 25, 2020
tests/br_debug_meta/run.sh
Outdated
Comment on lines
22
to
30
| run_sql "split table $DB.$TABLE by ('user6282602628620641459'), ('user6282603728132269670'), ('user6282604827643897881'), ('user6282610325202038936');" | ||
|
|
||
| run_sql "CREATE TABLE $DB.$TABLE( \ | ||
| YCSB_KEY varchar(64) NOT NULL, \ | ||
| FIELD0 varchar(1) DEFAULT NULL, \ | ||
| PRIMARY KEY (YCSB_KEY) \ | ||
| ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;" | ||
|
|
||
| run_sql "INSERT INTO $DB.$TABLE VALUES (\"a\", \"b\");" | ||
| run_sql "INSERT INTO $DB.$TABLE VALUES (\"aa\", \"b\");" | ||
| table_region_sql="SELECT COUNT(*) FROM information_schema.tikv_region_status WHERE db_name = '$DB' AND table_name = '$TABLE';" | ||
| for i in $(seq 10); do | ||
| regioncount=$(run_sql "$table_region_sql" | awk '/COUNT/{print $2}') | ||
| [ $regioncount -ge 5 ] && break | ||
| sleep 3 | ||
| done | ||
| run_sql "$table_region_sql" |
There was a problem hiding this comment.
SPLIT TABLE should be effective immediately, so no need to check region count again 🤔 (you could check the TOTAL_SPLIT_REGION field returned by SPLIT TABLE if you need to be absolutely sure)
btw there is also the SPLIT TABLE a BETWEEN ('aaaa') AND ('zzzz') REGIONS 5 syntax.
There was a problem hiding this comment.
It does split, however, data is not distributed to multiple regions, so I think just leave the loop and let TiKV splits.
Signed-off-by: Neil Shen <[email protected]>
|
/rebuild |
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
|
/run-integration-test Fails with #641 |
|
/run-integration-test |
2 similar comments
|
/run-integration-test |
|
/run-integration-test |
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
kennytm
reviewed
Dec 23, 2020
Co-authored-by: kennytm <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
|
/rebuild |
|
LGTM |
ti-srebot
approved these changes
Dec 24, 2020
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Dec 24, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #655 |
3pointer
pushed a commit
that referenced
this pull request
Dec 24, 2020
Signed-off-by: Neil Shen <[email protected]>
|
/run-cherry-picker |
|
cherry pick to release-5.0-rc failed |
ti-chi-bot
pushed a commit
that referenced
this pull request
Jul 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Speed up restore by merging small range to reduce split and scatter.
What is changed and how it works?
Merge adjacent ranges that total_bytes is less 96MB or total_kv is less than 960000.
Check List
Tests
Side effects
Breaking backward compatibilityRelease Note