-
Notifications
You must be signed in to change notification settings - Fork 101
err_msg: clarify some ambiguous error message (#1076) #1132
err_msg: clarify some ambiguous error message (#1076) #1132
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
45badad
to
7460321
Compare
pkg/task/restore.go
Outdated
@@ -203,7 +234,17 @@ func RunRestore(c context.Context, g glue.Glue, cmdName string, cfg *RestoreConf | |||
if err != nil { | |||
return errors.Trace(err) | |||
} | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a conflict.
/run-all-tests |
/lgtm |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
@Zwj-coder: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #1076
What problem does this PR solve?
Keeping improve BR errors and logs #1055
Some error message in BR is ambiguous and misleading.
i.e.
Clarify the summary info including:
data-size => total kv size
size => backup data size(after compressed)
What is changed and how it works?
data-size
field has been changed tototal-kv-size
size
field in backup summary has been changed tobackup data size(after compressed)
size
field in restore summary has been changed torestore data size(after decompressed)
Check List
Tests
Code changes
Release Note