-
Notifications
You must be signed in to change notification settings - Fork 101
backup: debounce fine-grained backup (#1036) #1037
backup: debounce fine-grained backup (#1036) #1037
Conversation
Signed-off-by: ti-srebot <[email protected]>
/lgtm |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 714d1ca
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
cherry-pick #1036 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/1037
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Sometimes, TiKV make empty response stream from backing up request. (This seems buggy, but not sure.)
In this condition, fine-grained backup would crazily send
backup
RPC, if there are enough resource, thing wouldn't be so bad: when PD make progress, real leader can be found, and everything should back to normal, but for our CI, the busiest node of our community, un, ya see.Note the timestamp. There are about 100k+ or even more logs like this.
What is changed and how it works?
Now, if fine-grained backup make no progress, it would backoff for 10 seconds.
The backoff time is an experience value, by analyzing the local log. Let's change it if necessary.
Check List
Tests
Release Note