Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mmh3 4.X as dependency #76

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Add mmh3 4.X as dependency #76

merged 4 commits into from
Mar 22, 2024

Conversation

mcpaddy
Copy link
Contributor

@mcpaddy mcpaddy commented Mar 14, 2024

Problem

pinecone-text and llama-index cannot be installed simultaneously because of a
dependency issue with mmh3. pinecone-text is locked to use 3.1 where llama-index uses version 4. or greater

Please note that version 4 of mmh3 had a breaking change with big-endian platforms.

Solution

Bump the supported version of mmh3. to include version 4.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Tested it locally


Before this patch mmh3 was locked to 3.1.*. This allows version 4
of mmh3 to be used.
update versions
@acatav acatav enabled auto-merge March 22, 2024 14:24
Copy link
Collaborator

@acatav acatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@acatav acatav added this pull request to the merge queue Mar 22, 2024
Merged via the queue into pinecone-io:main with commit 095e62c Mar 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants