Tweaks for better small screen layout and darker theme #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
southafricanrob
commented
Mar 17, 2015
southafricanrob
commented
- volume slider movies to header on small screens for easy access
- now playing moves to side panel on larger screens so always visible
- added right side settings panel in header to free up some space from Now Playing panel
- dark theme option similar to Spotify Web Player
- independently scrollable playlist and track list divs
added 7 commits
March 10, 2015 23:28
- Volume slider moves to header on small screens for easier access - Now Playing moves to side panel on large screens so always visible
-added right side settings panel in header to free space in the left panel for the Now Playing info -links to other Musicbox's on the same network (Work In Progress!) -option to choose a Dark Theme similar to Spotify's Web Player
- remove all the duplicate parts of the css that appears in both light and dark theme style sheets to reflect only the changes needed
- this css was inline and so couldn't be overridden in dark theme style sheet
- stops playlists from scrolling off screen when you scroll the tracks in a long playlist
- may as well move them here to clean up the Left Side Panel a bit more
Remove links to other musicbox's until ability to configure their IP's in settings.
|
I think we will hold off on 1) and 2), for now at least. Sadly my attempts at cherry-picking the rest are meeting with little cooperation from git. |
|
Closing this PR as these changes seem to have been taken further in #89 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.