Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist items are hidden if track lookup fails #226

Closed
jcass77 opened this issue Jan 28, 2017 · 0 comments
Closed

Playlist items are hidden if track lookup fails #226

jcass77 opened this issue Jan 28, 2017 · 0 comments

Comments

@jcass77
Copy link
Member

jcass77 commented Jan 28, 2017

When browsing playlists containing URI's to tracks that are no longer available in the library, MMW will fail silently and not display any of the available information for that track.

The failure occurs in

var newplaylisturi = resultDict.uri
playlists[newplaylisturi] = {'uri': newplaylisturi, 'tracks': []}
for (i = 0; i < trackUris.length; i++) {
playlists[newplaylisturi].tracks.push(tracks[trackUris[i]][0])
}
.

The desired behavior should probably be to log the error to the console and fall back to using the track Ref instead. Since the track also will not be playable, it might make sense to disable the context menu for the affected tracks as well, and maybe add '[Not playable]' to the track name?

@jcass77 jcass77 changed the title Empty playlist show if track lookup fails Playlist items are hidden if track lookup fails Jan 28, 2017
jcass77 added a commit to jcass77/Mopidy-MusicBox-Webclient that referenced this issue Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant