Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove double || in aggregated variables #34

Merged
merged 1 commit into from
Jan 21, 2025
Merged

remove double || in aggregated variables #34

merged 1 commit into from
Jan 21, 2025

Conversation

orichters
Copy link
Contributor

Purpose of this PR

Checklist:

  • I used ./test-standard-runs to compare and archive the changes introduced by this PR in /p/projects/edget/PRchangeLog/

johannah-pik
johannah-pik approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@johannah-pik johannah-pik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) Looks good to me!
In that case I would say your testing is sufficient and there is no need to test edget standalone/iterative compatibility

@orichters orichters merged commit f4eb08d into pik-piam:master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannah-pik johannah-pik johannah-pik approved these changes

@jmuessel jmuessel Awaiting requested review from jmuessel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orichters @johannah-pik