Skip to content

Commit

Permalink
Rollup merge of rust-lang#54773 - rust-lang:wesleywiser-patch-1, r=ol…
Browse files Browse the repository at this point in the history
…i-obk

Update a FIXME in memory.rs

In  rust-lang#51833, I improved the performance of `copy_undef_mask()`. As such, the old FIXME wasn't appropriate anymore. The main remaining thing left to do is to implement a fast path for non-overlapping copies (per @oli-obk).

r? @oli-obk
  • Loading branch information
pietroalbini authored Oct 3, 2018
2 parents 4a2ecc6 + d686896 commit 723f662
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/librustc_mir/interpret/memory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -971,7 +971,7 @@ impl<'a, 'mir, 'tcx, M: Machine<'a, 'mir, 'tcx>> Memory<'a, 'mir, 'tcx, M> {

/// Undefined bytes
impl<'a, 'mir, 'tcx, M: Machine<'a, 'mir, 'tcx>> Memory<'a, 'mir, 'tcx, M> {
// FIXME(solson): This is a very naive, slow version.
// FIXME: Add a fast version for the common, nonoverlapping case
fn copy_undef_mask(
&mut self,
src: Pointer,
Expand Down

0 comments on commit 723f662

Please sign in to comment.