Skip to content

Commit

Permalink
#33: fixes go module support breaking non module aware go versions, k…
Browse files Browse the repository at this point in the history
…udos to @snowzach
  • Loading branch information
pierrec committed Sep 6, 2018
1 parent 68a7290 commit bb6bfd1
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion bench_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"io/ioutil"
"testing"

lz4 "github.com/pierrec/lz4/v2"
"github.com/pierrec/lz4"
)

func BenchmarkCompress(b *testing.B) {
Expand Down
2 changes: 1 addition & 1 deletion block_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"reflect"
"testing"

lz4 "github.com/pierrec/lz4/v2"
"github.com/pierrec/lz4"
)

type testcase struct {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module github.com/pierrec/lz4/v2
module github.com/pierrec/lz4

require github.com/pkg/profile v1.2.1
2 changes: 1 addition & 1 deletion reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"io"
"io/ioutil"

"github.com/pierrec/lz4/v2/internal/xxh32"
"github.com/pierrec/lz4/internal/xxh32"
)

// Reader implements the LZ4 frame decoder.
Expand Down
2 changes: 1 addition & 1 deletion reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"strings"
"testing"

lz4 "github.com/pierrec/lz4/v2"
"github.com/pierrec/lz4"
)

func TestReader(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"fmt"
"io"

"github.com/pierrec/lz4/v2/internal/xxh32"
"github.com/pierrec/lz4/internal/xxh32"
)

// Writer implements the LZ4 frame encoder.
Expand Down
2 changes: 1 addition & 1 deletion writer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"reflect"
"testing"

lz4 "github.com/pierrec/lz4/v2"
"github.com/pierrec/lz4"
)

func TestWriter(t *testing.T) {
Expand Down

2 comments on commit bb6bfd1

@h8liu
Copy link
Contributor

@h8liu h8liu commented on bb6bfd1 Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi there,

could you be consistent about the usage of go1.11 modules?

  • ./fuzz/lz4.go
  • ./lz4c/main.go
  • ./internal/xxh32/xxh32zero_test

the files above are still using v2.

If the module file has been changed back to not using the v2 in the import path, then I believe everything else should also be reverted.

@pierrec
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Good point. Mind a pull request?

Please sign in to comment.