Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed icons disappearing on group classes on focus. #373

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Fixed icons disappearing on group classes on focus. #373

merged 1 commit into from
Jan 15, 2018

Conversation

ajm113
Copy link
Contributor

@ajm113 ajm113 commented Dec 29, 2017 •
edited
Loading

When user attempts to use the following.

<div class="input-group has-icon-left">
   <input type="text" class="form-input">
   <i class="form-icon icon icon-search"/>
  <button class="btn btn-primary input-group-btn" type="submit">Query</button>
</div>

The current behavior hides the icon on .form-input:focus. This pull request ensures the .form-icon will always appear above the child DOM. This should resolve this issue: #238

picturepan2
picturepan2 approved these changes Jan 15, 2018
View reviewed changes
Copy link
Owner

@picturepan2 picturepan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will re-compile it.

@picturepan2 picturepan2 changed the base branch from master to 0.5.1 January 15, 2018 05:23
@picturepan2 picturepan2 merged commit be24aac into picturepan2:0.5.1 Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picturepan2 picturepan2 picturepan2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajm113 @picturepan2