Add initial infrastructure #12
Conversation
smoia
added
the
Internal
|
Ok, I'm not sure it's working. @eurunuela can you have a look at it? I thought it would have tbh... Maybe I need to watch again your tutorial 😅 |
|
Okay, I see what the problem is. You didn't add the Makefile. So, the config file is pointing at the Makefile to run some commands; i.e. the |
|
It's now working as expected. You see the tests complain about the |
|
If you don't want to have the failing tests, you could comment out the tests you do not want to run just yet from line 206 down to the end of the |
|
CircleCI is complaining about the lack of flake8 though, is it because we don't have tests? |
|
No. That's cause you don't have flake8 on the |
Now I realize I forgot to mention that on the tutorial 🤣 |
|
Ok, now it should work. All tests are set up, but none is running atm, except for style checks. |
|
Any idea on why this is a problem here but not in phys2bids? |
What problem? There are no tests in If you're talking about the style check, you will have to tune the flake8 settings to ignore some errors. If that's what you want. |
phys2denoise.py
Outdated
| """ | ||
| Copyright 2019, The Phys2BIDS community. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| """ |
There was a problem hiding this comment.
I'm just curious- why is this in the actual file? Doesn't the LICENSE file at the top level apply to all files in the repository?
There was a problem hiding this comment.
We never understood - that's why we put it at the end of the main workflow in phys2bids!
|
Okay. The test work as you can see. I'm trying to figure out why the codecov call is not working. Did you give the codecov bot permissions @smoia ? |
|
You mean the problem of the merge_coverage test failing? Could it be because there is no actual test going on on the code? |
That's my second option if the bot has permissions 🤣 |
|
Yes, the bot seems to have permission! |
|
If anyone else can give a general check, we can merge this in asap! |
|
Ok, I'm going to merge in things for the moment. |
Closes #15
Proposed Changes
Complete the missing infrastructure used in other physiopy packages, such as: