Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define previously unspecified Exceptions in the main workflow #406

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Define previously unspecified Exceptions in the main workflow #406

merged 2 commits into from
Jun 18, 2021

Conversation

marcelzwiers
Copy link
Contributor

A very broad Exception was raised, which makes it hard to catch. Now two kind of exceptions are raised, 1) RuntimeError for invalid input data and 2) NotImplementedError if that is the case (before the broad 'Exception' base-class was raised)

Proposed Changes

raise Exception() -> raise RuntimeError / NotImplementedError

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

Improved Exception handling of phys2bids
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #406 (220fa32) into master (89aeabf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #406   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files           8        8           
  Lines         868      868           
=======================================
  Hits          823      823           
  Misses         45       45           
Impacted Files Coverage Δ
phys2bids/phys2bids.py 88.13% <100.00%> (ø)

Co-authored-by: Stefano Moia <[email protected]>
@smoia smoia changed the title Update phys2bids.py Define previously unspecified Exceptions in the main workflow Jun 18, 2021
@smoia smoia self-assigned this Jun 18, 2021
@smoia smoia added the Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) label Jun 18, 2021
@smoia smoia merged commit 6996d73 into physiopy:master Jun 18, 2021
@smoia
Copy link
Member

smoia commented Jun 18, 2021

🚀 PR was released in 2.6.0 🚀

@smoia smoia added the released This issue/pull request has been released. label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants