Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct chtrig check in phys2bids main workflow #390

Merged
merged 2 commits into from
Apr 11, 2021

Conversation

drombas
Copy link
Contributor

@drombas drombas commented Mar 10, 2021

Closes #389

Proposed Changes

  • Change chtrig check value from 1 to 0 (phys2bids.py)
  • Modify chtrig test to check that a negative value raises the exception (test_phys2bids.py)

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #390 (89c327c) into master (3b4ec90) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files           8        8           
  Lines         862      862           
=======================================
  Hits          817      817           
  Misses         45       45           
Impacted Files Coverage Δ
phys2bids/phys2bids.py 88.13% <100.00%> (ø)

@drombas
Copy link
Contributor Author

drombas commented Mar 29, 2021

Hi! anything preventing merging this?

Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smoia smoia self-assigned this Apr 11, 2021
@smoia smoia added the BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) label Apr 11, 2021
@smoia smoia merged commit e50e3cd into physiopy:master Apr 11, 2021
@smoia
Copy link
Member

smoia commented Apr 11, 2021

🚀 PR was released in 2.4.1 🚀

@smoia smoia added the released This issue/pull request has been released. label Apr 11, 2021
@drombas drombas deleted the fixbug-chtrig0 branch April 15, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phys2bids not working with chtrig=0
2 participants