Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the outcome of integration and documentation tests as downloadable artifacts from each Cirrus CI test page #384

Merged
merged 21 commits into from
Feb 23, 2021

Conversation

vinferrer
Copy link
Collaborator

@vinferrer vinferrer commented Feb 18, 2021

Closes Nothing

Proposed Changes

  • Now if you access the build docs job page you can check and download the html/docs when they finished. This is temporal, if we can use this: https://docs.readthedocs.io/en/stable/pull-requests.html much better but @smoia has to look into it
  • Now if you access the integration jobs pages you can check and download the results from integration jobs when they are finished

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@vinferrer vinferrer added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Feb 18, 2021
@vinferrer vinferrer requested review from tsalo and smoia February 18, 2021 08:21
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #384 (b556fc0) into master (bdf4480) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files           8        8           
  Lines         839      839           
=======================================
  Hits          794      794           
  Misses         45       45           

@smoia smoia changed the title Output the documentation and the integration tests results as artifacts Provide the outcome of integration and documentation tests as downloadable artifacts from each Cirrus CI test page Feb 22, 2021
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into the readthedocs settings and docuemtnation, but I can't understand why we don't have the automatic build (the settings are as they should be).

I'm totally happy with this solution! LGTM!

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great to me as well!

@vinferrer vinferrer merged commit 3b4ec90 into physiopy:master Feb 23, 2021
@smoia
Copy link
Member

smoia commented Apr 11, 2021

🚀 PR was released in 2.4.1 🚀

@smoia smoia added the released This issue/pull request has been released. label Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants